tag:blogger.com,1999:blog-917480286629905078.post9101219004492285052..comments2023-05-05T07:19:41.831-07:00Comments on Valyria Tear: Very first battle...Bertramhttp://www.blogger.com/profile/11010408540242098212noreply@blogger.comBlogger10125tag:blogger.com,1999:blog-917480286629905078.post-77539564404217356582012-08-31T12:30:59.201-07:002012-08-31T12:30:59.201-07:00Regarding the performance issue. It is only visibl...Regarding the performance issue. It is only visible when I run the program in windowed mode, not on fullscreen. So I think it has something to do with OpenGl.<br /><br />However, when I remember correctly, it was not the issue before even in windowed mode. I will try to find the commit where everything was smooth the last time. ;)<br /><br />Once I have found it, I will start an issue on GitHub.Anonymoushttps://www.blogger.com/profile/03470696409962781192noreply@blogger.comtag:blogger.com,1999:blog-917480286629905078.post-63231601825869151732012-08-29T01:28:10.704-07:002012-08-29T01:28:10.704-07:00Ok, np. Anyway, I've got a second patch for th...Ok, np. Anyway, I've got a second patch for the battle code making the command menu a bit more smart when speaking updating the enemy target and not stuck the player with ghost enemies. I'll push it asap.Bertramhttps://www.blogger.com/profile/11010408540242098212noreply@blogger.comtag:blogger.com,1999:blog-917480286629905078.post-84555607100029866022012-08-29T01:26:32.030-07:002012-08-29T01:26:32.030-07:00Read it and answered.
Speaking of which, I fear we...Read it and answered.<br />Speaking of which, I fear we might have to keep the equip menu, as I can't come with something smart yet. I'll give it more time to think about it.<br /><br />Also, sorry, but I can't add you as a collaborators on github, both as a user repo or an organization repo. Simply, because that would give you push access, something I'll retain under my evil dictatorship. ;><br />Anyway, github permits you to create pull request from your repository.<br />The best way to do it will be to create a branch from master<br />make commits there, and add it remotely.<br />Then you can create the pull requests, and we can discuss it.<br />I can help if you're unsure about that.<br /><br />Best regards,Bertramhttps://www.blogger.com/profile/11010408540242098212noreply@blogger.comtag:blogger.com,1999:blog-917480286629905078.post-34595766479998469872012-08-29T00:05:59.373-07:002012-08-29T00:05:59.373-07:00I will open an issue for the third point on GitHub...I will open an issue for the third point on GitHub.Anonymoushttps://www.blogger.com/profile/03470696409962781192noreply@blogger.comtag:blogger.com,1999:blog-917480286629905078.post-21238557457643514872012-08-29T00:05:20.231-07:002012-08-29T00:05:20.231-07:00I war trying to reproduce the effect. The first ti...I war trying to reproduce the effect. The first time I was facing the same problem, but in any later battle everything works fine. So I didn't open an issue yet. But I will keep my eyes open. ;)Anonymoushttps://www.blogger.com/profile/03470696409962781192noreply@blogger.comtag:blogger.com,1999:blog-917480286629905078.post-22595228434887194352012-08-28T01:40:21.814-07:002012-08-28T01:40:21.814-07:00"Furthermore, the game crashes after some for..."Furthermore, the game crashes after some forth and back in the battle menu. I think this problem is old but I thought it is already fixed. However, maybe I find some time to have a look in the code by myself."<br />Sorry, skipped that. Interesting, Could you open an issue on github and add how you do it? Thanks in advance.Bertramhttps://www.blogger.com/profile/11010408540242098212noreply@blogger.comtag:blogger.com,1999:blog-917480286629905078.post-63097730932057485592012-08-28T01:32:53.942-07:002012-08-28T01:32:53.942-07:00Hi nemesis!
Nice to see a white wolf from Allacro...Hi nemesis!<br /><br />Nice to see a white wolf from Allacrost around.<br /><br />I'll try to answer to best possible:<br />1. I'll need the commit in question. I don't doubt what you say, yet, it might as much be a question of bad coding or bad scripting, or even both. I know some profiling would be good, yet, I won't go into that without having the necessary features in place first, at least, as long as the game is playable ;)<br />Could you find it, I would be very glad to have some info about it.<br /><br />2. The battle bug should be gone with this commit (note that it only *should*):<br />https://github.com/Bertram25/ValyriaTear/commit/6e5f58fb1976a2321a95dc4383433122fbfa773e<br />I tried the exact scenario you told with it and I was able to finish the battle.<br />What is left and still lacking is that if you target the monster while another character kills it, you're still able to finish the command, whereas you should go back to the skill selection when the monster is dying instead. I'll fix that in a few days I guess.<br /><br />3. About your collaboration, whatever the feature or bug is, I'm glad you're around and you are welcome in the team. Yet, could you tell us a bit more about it (make some lightweight specs about it - It can be just a few lines)?<br />What I'd like you most to do is to open an issue on github with the tag 'comment & feedback', explaining how you want to make that.<br />The only rule I'd like you to keep in mind is that it must be **simple**, nice looking and **intuitive** for the user. So no plethora of options, no GUI cluttering, and no extra key fiddling, is the way to think, IMHO. (The shop mode is a little bit bad in that area for instance.)<br />Don't worry, you've got all the time you want to do it. ;)<br /><br />Feel free to fork Valyria Tear on github, and have a look at it, if not done already<br />I think I'll have to make hack conventions rather shortly to help in all that, but here are the vital ones:<br />- Tabs are accepted for now, but I'll change all that using a tool to use 4 spaces instead somewhere in the future.<br />- Never use: using namespace std; in new file, and remove them if you have the patience, since it's a very bad practice and is bad for the compile time.<br />- Never use: the defs.h file, use class x; ect at the beginning of your include file instead. The defs.h file is bad for compile time, and bad for the unlinking of the editor and the engine for instance, and last but no least, it shall perish somewhere in the future.<br />- Never include the big video.h if you can only include image.h, for instance.<br />The rest can be commented case by case, I guess. :)Bertramhttps://www.blogger.com/profile/11010408540242098212noreply@blogger.comtag:blogger.com,1999:blog-917480286629905078.post-75192340802089496862012-08-28T00:46:51.898-07:002012-08-28T00:46:51.898-07:00Hi, I followed your blog for a long time now and f...Hi, I followed your blog for a long time now and finally run the new code (startings one month ago or so). Really looks (still) nice.<br /><br />However, three comments so far:<br />1. For me it feels, that since one of your commits in the last two weeks or so, the game runs much slower (still playable for me but not so smooth anymore). Maybe it has something to do with your map particle effects. Did you or someone else face the same problems?<br /><br />2. Still some bug in the battle mode. When I target an enemy with Bronann and the girl kills this enemy before, I'm not able to finish the battle, since for Bronann in the next rounds I cannot target a new enemy. Furthermore, the game crashes after some forth and back in the battle menu. I think this problem is old but I thought it is already fixed. However, maybe I find some time to have a look in the code by myself.<br /><br />3. Did you thought about some thing like a quest log? I really like this in other games, especially, when the number of side quests increase. If you think this is a good idea, I can start programming something for this.<br /><br />I thought about rejoining the project since a few month, maybe I finally can find some time (if this is preferred by you and your team ;) ).<br /><br />Nemesis from the Allacrost project.Anonymoushttps://www.blogger.com/profile/03470696409962781192noreply@blogger.comtag:blogger.com,1999:blog-917480286629905078.post-28682069942439666912012-08-27T15:49:59.057-07:002012-08-27T15:49:59.057-07:00Hi Matt!
Nice to see you around. :)
(Have you go...Hi Matt!<br /><br />Nice to see you around. :)<br /><br />(Have you got a g+ profile btw?)<br /><br />I hope you'll enjoy what's being prepared.<br /><br />Best regards,Bertramhttps://www.blogger.com/profile/11010408540242098212noreply@blogger.comtag:blogger.com,1999:blog-917480286629905078.post-49137898682988914532012-08-27T02:49:25.620-07:002012-08-27T02:49:25.620-07:00Cool! Nice that you saved Allacrost :)Cool! Nice that you saved Allacrost :)Matthttps://www.blogger.com/profile/04056811343408273161noreply@blogger.com